specify/specify6

Borrow: ViewDev: yesNo1 referenced twice

mcruz-umich opened this issue · 3 comments

mcruz-umich commented

https://github.com/specify/specify6/blob/945d28f00288d2d64979848fb2fb63fda34bdd1b/config/common/common.views.xml#L1904C1-L1908C1

When uncommenting these fields, the occurrence of yesNo1 twice in the form causes the form to render blank.
Delete the second occurrence.

mcruz-umich commented

Also remove the hardcoded:
label="yesNo1"
label="yesNo2"

mcruz-umich commented

change id="6" on AddressOfRecord field to be id="AddressOfRecord" so it does not conflict with the viewname="BorrowAgent" id="6"

mcruz-umich commented

ID's for 9 and 10 for timestamps conflict with IDs used above.
Consider changing IDs to have the same value as the name field for each cell.

                <row>
                    <cell type="label" labelfor="9" />
                    <cell type="field" id="9" name="createdByAgent" uitype="label" readonly="true" uifieldformatter="Agent" />
                    <cell type="label" labelfor="10" />
                    <cell type="field" id="10" name="modifiedByAgent" uitype="label" readonly="true" uifieldformatter="Agent" />
                </row>
                <row>
                    <cell type="label" labelfor="11" />
                    <cell type="field" id="11" name="timestampModified" uitype="label" readonly="true" />
                    <cell type="label" labelfor="12" />
                    <cell type="field" id="12" name="timestampCreated" uitype="label" readonly="true" />
                </row>