Breaks custom domain setups (removes CNAME file)
peircej opened this issue · 5 comments
peircej commented
If a GH repo is set to serve its pages from a custom domain, GH inserts a file into the repo (CNAME
) but sphinx-notes then consistently deletes that file because of the line here
Line 85 in 5452140
which means that it constantly breaks custom domains.
I think we need rm -vrf * !("CNAME")
here
SilverRainZ commented
Previously I kept the CNAME file existing by the sphinx.ext.githubpages extension. Preventing it from removing is a good idea.
SilverRainZ commented
Pattern !("xxx")
seems not work:
bash-3.2$ ls
1 2 3 4
bash-3.2$ rm -vrf * !("1")
bash: !: event not found
bash-3.2$ ls
1 2 3 4
SilverRainZ commented
rm -vrf * !("1")
I should enable shell ext: shopt -s extglob
.
SilverRainZ commented
This is done in #13
SilverRainZ commented
This fix lands on v3.