sphinx-notes/pages

Use makefile instead of calling build-sphinx ?

peircej opened this issue · 1 comments

Users may have customised their makefile to include additional steps while building the html, but these are then lost when using because instead of calling
make html
it calls
sphinx-build -b html "$doc_dir" "$tmp_dir" $INPUT_SPHINX_OPTIONS

Is there any reason not to call like this?
make html BUILDDIR="$tmp_dir" SPHINXOPTS="$INPUT_SPHINX_OPTIONS"
which would, I think, achieve the same.

The only change later in main.sh would be

rm -rf $tmp_dir/.doctrees
cp -vr $tmp_dir/. $INPUT_TARGET_PATH

becomes

rm -rf $tmp_dir/html/.doctrees
cp -vr $tmp_dir/html/. $INPUT_TARGET_PATH

because make by default will add /html for that build

Sure, I will add this in v3.