Entities appear too bright
Closed this issue · 5 comments
I was playing on an SMP and I noticed that darker colored entities, namely spiders and endermen, appeared to be very bright.
Commit 56a31f7 just seem to fix this, but I can't explain this behavior. I will mark is as resolved for the time being and open another issue when I found the root cause.
The root cause seem to be F0 as expected.
F0--determined by index of refraction--represents base reflectivity which is assumed to be 0.04 for non-metals.
In reality each material has different base reflectivity which is too complicated to define individually. I thought 0.04 was low enough to not matter but it seem to cause every dark objects to appear too bright, including blocks.
The problem now is that I don't really know if this is an issue. For example, we don't know the index of refraction of Endermen skin to begin with. F0 wasn't supposed to be a controllable parameter unlike roughness and metallic. Though since I already made an assumption, I will probably make a different assumption that a material's F0 is affected by their texture brightness. Should work to fix the dark object problem at least.
I still can't explain why 56a31f7 fixed it though.