spotify/flink-on-k8s-operator

Rework Helm charts

regadas opened this issue · 8 comments

regadas commented

Helm charts are not in a good state right now as they are a bit disconnected from the kustomize resources.

We should align the definitions and make the charts a part of the release.

saminahbab commented

Can you show me where the kustomize resources are?
currently trying to use the helm chart, if you are telling me that the helm chart is critically wrong, then I would like to understand the best place to install from

Sudokamikaze commented

Also I would like to mention, Helm charts are using gen-cert.yaml which generates secret by openssl instead of relying on cert-manager (just like kustomization way does)
It should be reworked as well as it doesn't work right now:

"creationTimestamp":<nil> "name":"webhook-server-cert" "namespace":"flink-operator-system"]]}
from server for: "STDIN": secrets "webhook-server-cert" is forbidden: User "system:serviceaccount:flink-operator-system:flink-sa" cannot get resource "secrets" in API group "" in the namespace "flink-operator-system"

In logs on cert-job job

heumsi commented

Is there any further progress?
I have same problem still.

jiamin13579 commented

I try to fix it
#460

nickcaballero commented

Tried to address by updating the existing script - #500.

nickcaballero commented

Given that the update_template.sh is now sourcing directly from the Kustomize output, is the next step here to somehow incorporate the Helm chart updates as part of new releases?

  • ❤️1
regadas commented

@nickcaballero short answer to that is yes! :)