square/flow

MultiKey -> HistoryFrame?

loganj opened this issue · 3 comments

There's a lot of confusion around how MultiKeys and other keys interoperate. In practice, an app that uses MultiKeys will likely only want MultiKeys in its History. (Somebody stop me if I'm wrong, here). There's a 0,1,N thing happening.

The right thing to do here may be:

  1. Rename MultiKey to HistoryFrame.
  2. Change History so that it's always composed of HistoryFrames.

This would provide more clarity and structure around History and orient the API toward the common/general case.

A confounding factor is defining the behavior of the navigation methods when called with a simple key. This is the main reason defining MultiKeys is largely left as an exercise for the app author today.

rjrjr commented

I don't think we should make any drastic behavioral changes for 1.0. We're
still learning to live with these.

On Fri, Sep 2, 2016, 6:26 AM Logan Johnson notifications@github.com wrote:

There's a lot of confusion around how MultiKeys and other keys
interoperate. In practice, an app that uses MultiKeys will likely only
want MultiKeys in its History. (Somebody stop me if I'm wrong, here).
There's a 0,1,N thing happening.

The right thing to do here may be:

  1. Rename MultiKey to HistoryFrame.
  2. Change History so that it's always composed of HistoryFrames.

This would provide more clarity and structure around History and orient
the API toward the common/general case.

A confounding factor is defining the behavior of the navigation methods
when called with a simple key. This is the main reason defining MultiKeys
is largely left as an exercise for the app author today.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#208, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzBHX00XKb1ZP7ISHB1WIRnsm00Rf6xks5qmCP1gaJpZM4JztGT
.

WFM. Do think MultiKey should stop being a key though.

rjrjr commented

Totally agree there. And a name change if we can come up with one. KeyMap?
KeyChain :) ?

On Fri, Sep 2, 2016, 7:16 AM Logan Johnson notifications@github.com wrote:

WFM. Do think MultiKey should stop being a key though.


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#208 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABzBHZXSu2QhMhErRIZU_4ZMsQQw-O9Fks5qmC-hgaJpZM4JztGT
.