stan-dev/loo

Possibly missing cleanup?

sims1253 opened this issue · 1 comments

While working on my PR I noticed that there were a lot of pending changes after running build & install and even more after running styler::style_pkg(). I don't know if this is on purpose but figured it couldn't hurt to ping you.
(After Build & Install)
image
(After styling)
image

Thanks for the heads up!

there were a lot of pending changes after running build & install

I think this is due to the fact that the recent roxygen2 update made some changes that result some small differences in how Rd files are generated. I will go ahead and update those. Appreciate the ping!

styler::style_pkg()

This enforces a particular style of code used in the tidyverse. I like that style but we don't adhere to it 100% (we mostly follow it just not entirely), so that's why there are so many differences. Maybe at some point we'll decide to follow it exactly, but I'm not quite ready to make that decision.