standardrb/standard

LSP server registration of executeCommand `standardRuby.formatAutoFixes` breaks VS Code

Closed this issue · 0 comments

After fixing the capabilities registration of the server in #543, the VS Code extension stops working

[client] Starting language server: bundle exec standardrb --lsp
[client] Language server initialization failed: Error: command 'standardRuby.formatAutoFixes' already exists
[Error - 7:58:23 AM] Standard Ruby client: couldn't create connection to server.
Error: command 'standardRuby.formatAutoFixes' already exists
	at c.registerCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:96:107257)
	at Object.registerCommand (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:117:29964)
	at fl.register (/Users/justin/.vscode/extensions/testdouble.vscode-standard-ruby-0.0.15/out/extension.js:37:69450)
	at fl.initialize (/Users/justin/.vscode/extensions/testdouble.vscode-standard-ruby-0.0.15/out/extension.js:37:69033)
	at ud.initializeFeatures (/Users/justin/.vscode/extensions/testdouble.vscode-standard-ruby-0.0.15/out/extension.js:39:19137)
	at ud.doInitialize (/Users/justin/.vscode/extensions/testdouble.vscode-standard-ruby-0.0.15/out/extension.js:39:7570)
	at process.processTicksAndRejections (node:internal/process/task_queues:96:5)
	at async ud.start (/Users/justin/.vscode/extensions/testdouble.vscode-standard-ruby-0.0.15/out/extension.js:39:4599)
	at async pd (/Users/justin/.vscode/extensions/testdouble.vscode-standard-ruby-0.0.15/out/extension.js:41:5370)
	at async pT (/Users/justin/.vscode/extensions/testdouble.vscode-standard-ruby-0.0.15/out/extension.js:41:7414)
	at async f.n (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:94:6818)
	at async f.m (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:94:6781)
	at async f.l (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:94:6238)
[server] Standard Ruby v1.25.4 LSP server initialized, pid 70935
[server] Client asked to shutdown Standard LSP server.
[server] Exiting...

This is probably an indication the server doesn't need to advertise this feature, as it's defined inside the VS Code extension. I added it out of caution to the server registration but apparently that was not necessary. We should probably remove reference to it