stdlib-js/stdlib

[RFC]: Add C implementation for `@stdlib/math/base/special/minmax`

Opened this issue · 3 comments

anirudhprabhakaran3 commented

Description

This RFC proposes to add a C implementation for @stdlib/math/base/special/minmax

Related Issues

Progresses #649

Questions

  • I note that the implementations of min and max are already available. Should the C implementation exactly follow the logic in the JS files, or could it use the min and max functions in C while maintaining the same function signature and return values?

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
kgryte commented

@anirudhprabhakaran3 Sorry to be the bearer of bad news, but there is already a PR up for minmax: #1939.

anirudhprabhakaran3 commented

Aah😔 seems like I have the worst luck coming to this!

Aditya8840 commented

@kgryte I'd like to work on this.