[RFC]: Add C implementations to base special math functions (tracking issue)

Question

[RFC]: Add C implementations to base special math functions (tracking issue)

kgryte opened this issue 2 years ago · 8 comments

Answer 1 · 2024-03-05T04:51:25.000Z

@kgryte I would like to work on this.

Answer 2 · 2024-03-06T21:09:28.000Z

@Pratik772846 I suggest picking one of the associated RFCs for updating a single package. This is a tracking issue.

Answer 3 · 2024-03-06T21:10:51.000Z

@Pranavchiku As you've been managing a number of the RFCs and PRs, would you mind updating the OP to match the current state of implementations?

Answer 4 · 2024-03-12T13:45:25.000Z

I am not sure if this can be closed now, reopening this.

Answer 5 · 2024-03-12T13:46:59.000Z

@Pranavchiku Yeah, I think GitHub unfortunately auto-closes it when we have a PR where the opening comment includes "Fixes #649" or something of the sort. Thanks for opening again!

But I see that I accidentally included "Closes #649" in the merge commit message. Will avoid and see whether that solves it going forward.

Answer 6 · 2024-03-12T14:32:07.000Z

No worries, we can open it anytime so that is fine. Updated tracker to latest main.

Small script, not sure if it traps all cases. There can be false negatives but no false positives.

set -ex

# iterate over all folder in <.../math/base/special/*>
for d in <path>; do
  # if the folder is a directory
  if [ -d "$d" ]; then
	# get the name of the folder
	folder=$(basename $d)
	# check if it has `manifest.json` file
	if [ -f "$d/manifest.json" ]; then
		# if it has `manifest.json` file, then open it as j_, lookup js_[confs][dependencies] and see if it has "@stdlib/math/base/napi/unary"
		# if it has "@stdlib/math/base/napi/unary" then add it to the `names.md`
		jq -r '.jsdoc.confs.dependencies["@stdlib/math/base/napi/unary"]' $d/manifest.json
		if [ $? -eq 0 ]; then
			echo "- [x] $folder" >> names.md
		else
			echo "- [ ] $folder" >> names.md
		fi
	else
		echo "- [ ] $folder" >> names.md
	fi
  fi
done

Answer 7 · 2024-03-12T21:13:48.000Z

@Planeshifter You should always check the PR OP to ensure it properly links to issues and does not auto-close tracking issues. I often correct contributor PR OPs as they commonly include errors, including linking to incorrect issues or closing tracking issues.

Answer 8 · 2024-03-26T11:48:53.000Z

Updated as per latest develop

[RFC]: Add C implementations to base special math functions (tracking issue)

Description

Packages

Related Issues

Questions

Other

Checklist