stripe/stripe-js

[BUG]: types of address attributes differ marginally

SerafinDinges opened this issue · 2 comments

What happened?

This is a real nitpick but I still wanted to check: Is there a specific reason the properties on AccountAddressParam and Address are typed differently?

If you take line2 as an example it's typed as line2?: string one time and as line2: string | null another time. This means that we need to recast the address object we received from Stripe when we send it back to Stripe unchanged in order to make it type safe.

Not a big deal, as I said but I was still curious. Thank you!

Environment

No response

Reproduction

No response

Thanks for highlighting this. I don't think there's meant to be a meaningful difference here, so I've raised with the team to take a look.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.