Missing fastmath flag in some njit functions
Closed this issue · 1 comments
As mentioned in PR #1025 (See this comment), all njit functions must have fastmath flag. This issue is created so that this can be addressed separately. After that, we can resume PR #1048 and finish it. Then, we can resume the work on #1025. ( I am trying to stay on the current track as much as possible while addressing "necessary" changes.)
I've created the script check_fastmath.py in the root directory and executed it via ./test.sh. The tests fail which is expected. So, the next step is to add fastmath flags to those njit functions.
@seanlaw
Do you think creating this new issue complicates our flow? If not, I can push the changes from my local branch to remote branch.
Do you think creating this new issue complicates our flow? If not, I can push the changes from my local branch to remote branch.
No, it's fine as long as we wrap everything up ASAP (let me know if you'd like me to step step in for anything).
I've created the script check_fastmath.py in the root directory and executed it via ./test.sh. The tests fail which is expected. So, the next step is to add fastmath flags to those njit functions.
Instead of having two separate fastmath scripts (njit_fastmath.py and check_fastmath.py), maybe we should have one script called fastmath.py that includes the njit_fastmath.py script in #1025 as well as check_fastmath.py in your comment? You can use argparse to add keyword flags like ./fastmath.py check