Enable user to change Mach number and Reynolds Number from Python Interface
kursatyurt opened this issue · 2 comments
I want to introduce two new interfaces to change the Freestream Mach number and Reynolds Numbers from the Python interface.
As there are many parameters (mostly non/dimensional) affected by those two values I would like to get your insights on the viability and potential drawbacks of offering such an interface. Your thoughts on this matter would be greatly appreciated.
You would need to make some changes to the code to ensure that Mach number is always obtained from CConfig, currently we convert mach number to freestream velocity in some solvers and work with that instead.
There are also some convective schemes that store a copy of the Mach number when they are constructed.
Reynolds number would probably be a pain because it may affect quite a few things in SetNonDimensionalization.
It looks more complicated than I initially assumed. Without Reynolds's number change, Mach's number change does not make sense. For me, at the moment, it is not worth investing some time in implementation.