Wget Footer Command Fails When Directory Contains Apostrophe's in the Name
d-air1 opened this issue · 3 comments
d-air1 commented
Example folder title "The Rabbit's Foot"
Generated wget command
wget -rcnHp -R 'index.html*' 'http://localhost:9991/The%20Rabbit's%20Foot/?raw=true'
The issue is here is that the apostrophe after the word Rabbit
acts as a closing quote. This makes the apostrophe after the word true
a dangling starting quote.
Perhaps switch to double quotes for the outside of the command?
svenstaro commented
I think it'd be better to just properly escape these as otherwise people with "
in file names will run into the same problems. Would you like to take a stab at fixing this?
d-air1 commented
I don't mind taking a stab at it, but I'm not really familiar with rust.
…On Tue, Aug 1, 2023, 5:30 PM Sven-Hendrik Haase ***@***.***> wrote:
I think it'd be better to just properly escape these as otherwise people
with " in file names will run into the same problems. Would you like to
take a stab at fixing this?
—
Reply to this email directly, view it on GitHub
<#1190 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJWDUHSETUDRT4A4Y2JU6P3XTF7RNANCNFSM6AAAAAA3ALE6O4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
d-air1 commented
Closing since the PR was merged.