svenstaro/miniserve

Configuration with Environment variables

Closed this issue · 6 comments

genofire commented

It would be really nice, to configurate miniserve with env variables.

(In k8s it is possible to store Password safe in "Secrets" and use them as envFrom with secretRef - so basic auth credentials could be stored secure.)

svenstaro commented

Yeah, we should be able to get this functionality with very little effort thanks to clap as it's built-in. Want to take a stab at it?

onedr0p commented

@svenstaro Doesn't look to hard, you can see how dufs added support here
sigoden/dufs#170

svenstaro commented

Yeah should be pretty simple. Would you like to make a PR? I'm not sure when I'd get to it.

onedr0p commented

I am not familiar with Rust, nor use miniserve... only a has-been developer here 😆 I was just looking around for alternative options to filebrowser which I am currently using.

svenstaro commented

Can you guys check whether #1160 works for you?

onedr0p commented

Looks good to me, thanks! @svenstaro

  • 👍1