Do you accept contributions for wrappers over JavaScript objects?

Question

Do you accept contributions for wrappers over JavaScript objects?

revolter opened this issue 4 years ago · 4 comments

For example, would you accept a JSFileReader class, similar to JSDate, which would wrap FileReader?

Answer 1 · 2021-03-16T13:11:32.000Z

IMO JavaScriptKit should only contain portable classes — ones that would work in most (if not all) JS environments. DOM-specific types like FileReader would be better off in DOMKit, which is in need of finishing, if you’re interested.

Answer 2 · 2021-03-16T19:27:16.000Z

I agree, JavaScriptKit is only supposed to wrap APIs that are available across all JavaScript runtimes, including Node.js. DOMKit is a better fit for browser-specific stuff, and there we try to get these wrappers automatically generated. I don't remember if FileReader is covered by our codegen off the top of my head...

Answer 3 · 2021-03-16T20:00:12.000Z

Here’s FileReader: https://github.com/swiftwasm/DOMKit/blob/e45d37fbfddbe982a612f577d41ade85bab1bfbc/Sources/DOMKit/WebIDL/FileReader.swift

Answer 4 · 2021-03-16T21:07:03.000Z

Amazing! You are the best maintainers in the world ❤️