GCDWebServerOption_TXTRecordDictionary?

Question

GCDWebServerOption_TXTRecordDictionary?

Closed this issue 5 years ago · 8 comments

I'm replacing an older version of GCDWebServer where I use the TXTRecordDictionary for Bonjour broadcast. Why was this removed and how can I get it back in? Seems like something so simple that was removed?

Answer 1 · 2020-02-09T21:22:06.000Z

I don't recall exactly as it's very old but it was most likely due to this setting being unreliable. Or maybe it was deprecated or not fully supported or something. There had to be a good reason at the time.

Answer 2 · 2020-02-10T04:38:08.000Z

I don't recall exactly as it's very old but it was most likely due to this setting being unreliable. Or maybe it was deprecated or not fully supported or something. There had to be a good reason at the time.

This isn't a very good answer since I need this to continue to use your product as a Cocoapod. We need to broadcast information via Bonjour. I found the patch request from 2015 and implemented and it's not deprecated or fully supported or something... it seems pretty straightforward and reliably used by hundreds of thousands of our users. It does not effect any users unless it's used so I'm not sure why it would have been removed. When can we expect this to be restored? 3b75314

Answer 3 · 2020-02-10T04:44:06.000Z

I took the liberty of checking. The following calls that are made for this feature are alive and well and working in macOS Catalyst. They are not deprecated so I see no reason to not implement this.

https://developer.apple.com/documentation/cfnetwork/1426572-cfnetservicecreatetxtdatawithdic?language=objc

https://developer.apple.com/documentation/cfnetwork/1426670-cfnetservicesettxtdata?language=objc

Answer 4 · 2020-02-10T04:55:11.000Z

Finding the commit that removed this feature should hopefully provide the missing context.

…

On Sun, Feb 9, 2020 at 8:44 PM Jason Kichline ***@***.***> wrote: I took the liberty of checking. The following calls that are made for this feature are alive and well and working in macOS Catalyst. They are not deprecated so I see no reason to not implement this. https://developer.apple.com/documentation/cfnetwork/1426572-cfnetservicecreatetxtdatawithdic?language=objc https://developer.apple.com/documentation/cfnetwork/1426670-cfnetservicesettxtdata?language=objc — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#458?email_source=notifications&email_token=AAEZJS25HFDZLRNIZ2L7IHDRCDLRNA5CNFSM4KRDQPX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELHGUOI#issuecomment-583952953>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEZJS7ZNETGH6HISZLONYTRCDLRNANCNFSM4KRDQPXQ> .

Answer 5 · 2020-02-10T17:53:18.000Z

So I don't know how you found this commit 3b75314 but it's not on master. This feature never shipped as part of GCDWebServer. You must have been on a branch or fork, I have no clue.

There's also no trace in the history of the codebase of a GCDWebServerOption_TXTRecordDictionary option.

Answer 6 · 2020-02-10T18:34:42.000Z

I'm not sure. I had downloaded GCDWebServer from GitHub before CocoaPods. I can try to figure out where it was downloaded from, but it wasn't a branch that I was aware of. All I know is that we have this installed as source code since January 2014 is it was likely downloaded in late 2013. At this point however, I need to use the CocoaPods moving forward and it's now missing in the build.

Answer 7 · 2020-02-10T19:10:20.000Z

GCDWebServer was added to our project on December 5, 2013. Being that CocoaPods didn't launch its first version until December 30, 2015, I had downloaded it from your site at some point and had not updated it significantly since then. So as far as I can tell, this Bonjour capability has been in the framework since we started using it in 2013. ¯_(ツ)_/¯

It looks like I had downloaded a version of the GCDWebServer code again in 2017 that reorganized the framework into folders such as "Core" and that was updated on our end in August 2017, but appears to have copyright marker of 2012-2015. If I dig back further it looks like the method that included TXT data was in place December 13, 2013. The branch that I mentioned wasn't until 2015 so I'm a bit confused.

Answer 8 · 2020-02-10T20:30:45.000Z

If this patch works for you, you should simply fork the repo and apply it onto master, verify it all works then send a PR

…

On Mon, Feb 10, 2020 at 11:10 AM Jason Kichline ***@***.***> wrote: GCDWebServer was added to our project on December 5, 2013. Being that CocoaPods didn't launch its first version until December 30, 2015, I had downloaded it from your site at some point and had not updated it significantly since then. So as far as I can tell, this Bonjour capability has been in the framework since we started using it in 2013. ¯_(ツ)_/¯ It looks like I had downloaded a version of the GCDWebServer code again in 2017 that reorganized the framework into folders such as "Core" and that was updated on our end in August 2017, but appears to have copyright marker of 2012-2015. If I dig back further it looks like the method that included TXT data was in place December 13, 2013. The branch that I mentioned wasn't until 2015 so I'm a bit confused. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#458?email_source=notifications&email_token=AAEZJS6LTJCIIYM2OBLHUH3RCGRB3A5CNFSM4KRDQPX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELJ3PZA#issuecomment-584300516>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEZJS3U3IWVJ75OJARMJQ3RCGRB3ANCNFSM4KRDQPXQ> .