master tests failing
dbu opened this issue · 7 comments
tests on master are failing. seems that Testing expects KnpMenuBundle to be available, but it isn't. i thought that is a requirement of sonata admin, so either something got wrong there, or something else is wrong.
locally i can't get composer to install the deps of this bundle, i get
Problem 1
- Conclusion: don't install sonata-project/block-bundle 2.2.x-dev
- Installation request for sonata-project/doctrine-phpcr-admin-bundle 1.1.* -> satisfiable by sonata-project/doctrine-phpcr-admin-bundle[1.1.x-dev].
- Conclusion: don't install sonata-project/block-bundle 2.2.8|install sonata-project/block-bundle 2.2.x-dev
- sonata-project/doctrine-phpcr-admin-bundle 1.1.x-dev requires sonata-project/admin-bundle ~2.2.7 -> satisfiable by sonata-project/admin-bundle[2.2.7, 2.2.8, 2.2.9, 2.2.x-dev].
- sonata-project/admin-bundle 2.2.x-dev requires sonata-project/block-bundle ~2.2,>=2.2.7 -> satisfiable by sonata-project/block-bundle[2.2.7, 2.2.8, 2.2.x-dev].
- sonata-project/admin-bundle 2.2.9 requires sonata-project/block-bundle ~2.2,>=2.2.7 -> satisfiable by sonata-project/block-bundle[2.2.7, 2.2.8, 2.2.x-dev].
- sonata-project/admin-bundle 2.2.8 requires sonata-project/block-bundle ~2.2,>=2.2.7 -> satisfiable by sonata-project/block-bundle[2.2.7, 2.2.8, 2.2.x-dev].
- sonata-project/admin-bundle 2.2.7 requires sonata-project/block-bundle ~2.2,>=2.2.7 -> satisfiable by sonata-project/block-bundle[2.2.7, 2.2.8, 2.2.x-dev].
- Conclusion: don't install sonata-project/block-bundle 2.2.7|install sonata-project/block-bundle 2.2.8|install sonata-project/block-bundle 2.2.x-dev
The Testing component requires it when loading the sonata bundle set: https://github.com/symfony-cmf/Testing/blob/master/src/Symfony/Cmf/Component/Testing/HttpKernel/TestKernel.php#L50
After looking at sonata's composer.json files, I can't discover any knp package in there. However, the code requires the KnpMenuBundle. It looks like this is a problem in sonata, @rande
OK, seems like an undocumented regression in the SonataAdminBundle. The dependencies for KnpMenu 2.0 were added 11 days ago in sonata-project/SonataAdminBundle@6fc4f04 and 5 days ago, all knp requirements where removed in sonata-project/SonataAdminBundle@fb0bd9c and an error message saying:
Boom! you are living on the edge ;) The AdminBundle requires the KnpMenuBundle!
Please add either"knplabs/knp-menu-bundle": "~1.1",if you want the stable version or"knplabs/knp-menu-bundle": "~2.0@dev"and"knplabs/knp-menu": "~2.0@dev",into your composer.json file if you want the MopaBootstrapBundle-compatible version and add the KnpMenuBundle into the AppKernel');
Was added. This means all bundles requiring the SonataAdminBundle for their tests needs to be updated to also require "knplabs/knp-menu-bundle": "~1.1".
We can reintroduce the dependency to support both version:
"knplabs/knp-menu-bundle":
"*"
On Tue, Jan 7, 2014 at 10:12 PM, Wouter J notifications@github.com wrote:
OK, seems like an undocumented regression in the SonataAdminBundle. The
dependencies for KnpMenu 2.0 were added 11 days ago in
sonata-project/SonataAdminBundle@6fc4f04sonata-project/SonataAdminBundle@6fc4f0400ea6efe27ecc997105d5f2228c94c6aeand 5 days ago, all knp requirements where removed in
sonata-project/SonataAdminBundle@fb0bd9chttps://github.com/sonata-project/SonataAdminBundle/commit/fb0bd9c9dd2a3a863a3ed425f38400bec7feec22and an error message saying:Boom! you are living on the edge ;) The AdminBundle requires the
KnpMenuBundle!
Please add either "knplabs/knp-menu-bundle": "~1.1", if you want the
stable version or "knplabs/knp-menu-bundle": "~2.0@dev" and "knplabs/knp-menu":
"~2.0@dev", into your composer.json file if you want the
MopaBootstrapBundle-compatible version and add the KnpMenuBundle into the
AppKernel');Was added. This means all bundles requiring the SonataAdminBundle for
their tests needs to be updated to also require "knplabs/knp-menu-bundle":
"~1.1".—
Reply to this email directly or view it on GitHubhttps://github.com//issues/167#issuecomment-31779822
.
Thomas Rabaix
http://rabaix.net | http://sonata-project.org
http://rabaix.net
@rande did you bump the requirement to KnpMenuBundle 2.0? or can you work with either? then the correct thing would be knplabs/knp-menu-bundle: ">=1.1.0,<3.0.0" afaik
The situation with some bundles is not very good. KnpMenuBundle and
FosUserBundle have been on 2.0-dev for more than 12 months or so with no
stable release. Also some widely used bundles (MopaBootstrapBundle, and
many others) are using them with their non stable version.
What should we do ? We try to support them both version. For KnpMenuBundle
this is quite easy and the AdminBundle support 1.X and 2.X branch. So I
will update the composer.json to avoid issue on third party bundles.
The situation is more complex with FosUserBundle and we don't have a
solution yet.
As a side note, we try to reduce the amount of code in the AdminBundle:
- remove the built in bootstrap theme, and use MopaBootstrapBundle (or
bower). As it is a major BC break, we have only migrate front layouts of
all sonata's bundles (but not the Admin part) - migrate the filter part into a dedicated bundle, that can be used with
pagerfanta or knp paginator.
On Wed, Jan 8, 2014 at 7:46 AM, David Buchmann notifications@github.comwrote:
@rande https://github.com/rande did you bump the requirement to
KnpMenuBundle 2.0? or can you work with either? then the correct thing
would be knplabs/knp-menu-bundle: ">=1.1.0,<3.0.0" afaik—
Reply to this email directly or view it on GitHubhttps://github.com//issues/167#issuecomment-31809415
.
Thomas Rabaix
http://rabaix.net | http://sonata-project.org
http://rabaix.net
Should be ok with sonata-project/SonataAdminBundle@0100f0e
limit cmf block bundle to sonata-block-bundle <2.2.8 and sonata-cache-bundle <2.1.6 (cache did not start to depend on corebundle, but we want to be on the safe side) also both in 1.0 and master