Invalid read of size 4

Question

Invalid read of size 4

Closed this issue 4 years ago · 9 comments

Memory checking a program with valgrind returns an invalid read of size 4 in at line 10533 of sod.c.

Minimal example code :

#include <stdlib.h>
#include <math.h>
#include "sod.h"

int main(int argc, char *argv[]) {
	const char *zInput = argv[1];
	sod_img imgIn = sod_img_load_grayscale(zInput);
	sod_img cannyImg = sod_canny_edge_image(imgIn, 0);
	sod_free_image(cannyImg);
	return 0;
}

Valgrind output after compilation in Ubuntu 18.04 amd 64 :

==17492== Invalid read of size 4
==17492==    at 0x1286F8: canny_non_max_suppression (sod.c:10533)
==17492==    by 0x129D0E: sod_canny_edge_image (sod.c:10832)
==17492==    by 0x10B534: main (minimal.c:8)
==17492==  Address 0x4d57f00 is 0 bytes after a block of size 473,600 alloc'd
==17492==    at 0x483AB35: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==17492==    by 0x1234A3: sod_make_image (sod.c:9190)
==17492==    by 0x129C67: sod_canny_edge_image (sod.c:10827)
==17492==    by 0x10B534: main (minimal.c:8)
==17492==

Answer 1 · 2019-08-22T01:00:09.000Z

Yes, this is an issue with memory allocation of an array that may run out of bound in some cases. A fix is to be pushed in the coming weeks with the next release of the library.

Answer 2 · 2019-08-22T07:34:51.000Z

Ok, good to know you are aware of that 👍.

I also faced a memory leak in canny detector which sometimes leaks 128 bytes and sometimes not ? I am still trying to discover how exactly but it is happening around line 966 in SysSetPut

Answer 3 · 2019-08-22T07:38:53.000Z

Is it reproducible from the same code snippet? Could you share your valgring output, any gdb stack trace?

…

-----Original Message----- From: "Pierre-André Mudry" <notifications@github.com> To: symisc/sod <sod@noreply.github.com> Cc: Symisc Systems <chm@symisc.net>, Comment <comment@noreply.github.com> Sent: Thu, 22 Aug 2019 8:34 Subject: Re: [symisc/sod] Invalid read of size 4 (#16) Ok, good to know you are aware of that 👍. I also faced a memory leak in canny detector which sometimes leaks 128 bytes and sometimes not ? I am still trying to discover how exactly but it is happening around line 966 in `SysSetPut`

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #16 (comment)

Answer 4 · 2019-08-22T11:44:04.000Z

For the memory leak, I am sorry the problem was on my side. I was not always releasing the lines while doing hough lines detection.

Everything fine there. Nice work by the way !

Answer 5 · 2019-09-03T12:42:19.000Z

Any idea when the next library release will be coming out ?

Answer 6 · 2019-09-03T13:00:47.000Z

Yes, it should be released in late October, early November of this year. You will be notified from Github if you are a watcher of the library. Symisc Systems, SUARL

…

-----Original Message----- From: "Pierre-André Mudry" <notifications@github.com> To: symisc/sod <sod@noreply.github.com> Cc: Symisc Systems <chm@symisc.net>, Comment <comment@noreply.github.com> Sent: Tue, 03 Sep 2019 13:42 Subject: Re: [symisc/sod] Invalid read of size 4 (#16) Any idea when the next library release will be coming out ?

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: #16 (comment)

Answer 7 · 2019-11-28T21:16:47.000Z

Any news on the new library release ?

Cheers

Answer 8 · 2019-12-02T03:41:16.000Z

The release is scheduled for January 2020 due time constraint and developers focusing on a global scale product powered by SOD. We have managed to fix the canny edge issue and adding new image processing interfaces. Stay tune!

Answer 9 · 2020-03-03T01:04:35.000Z

Make sure to update to the latest version of SOD which fix the canny edge detection memory leak issue https://sod.pixlab.io/changelog.html