Update to 1.41.1
Closed this issue · 8 comments
VS Code 1.41.1 has been released.
https://github.com/Microsoft/vscode/issues?q=is%3Aissue+milestone%3A%22November+2019+Recovery%22+is%3Aclosed
- Update repo to 1.41.1
- Commit to the port tree
Hi @pizzamig,
I have update to the VSCode repo to 1.41.1. Can you check and commit the changes?
Please update electron as well, requested at tagattie/FreeBSD-Electron#32.
So it seems that this finally landed in the ports tree recently, but when I try to build the port in poudriere, it fails on me from what looks to be an attempt to use the Internet for marketplace extensions? I'm not 100% sure, but the failure build log can be found here:
(Note: The only change I've made to the port is to use the patch in issue #12 to support Node 13.)
Hi @CyberBotX,
Thanks for the report. According to the log, it did attempt to download marketplace extensions and failed. I guess the issue can be solved by renaming a patch file as follows:
cd ${FILESDIR}
mv extra-patch-build_gulpfile.extensions.js patch-build_gulpfile.extensions.js
The patch, which was applied only when POUDRIERE option was defined, should be now applied unconditionally.
Hi @pizzamig,
Thanks for committing the changes along with electron6. There seems one leftover with the latest update and the port seems now broken (see #17 (comment))
Could you rename the following file in ${FILESDIR} to unbreak the build?
extra-patch-build_gulpfile.extensions.js to patch-build_gulpfile.extensions.js
Hi @tagattie , I got the same error and it was fixed by renaming extra-patch-build_gulpfile.extensions.js to patch-build_gulpfile.extensions.js. I have built VS Code package successfully with poudriere after renaming the patch.
Thanks!
This issue is now also at FreeBSD Bugzilla:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=243994
@pizzamig, I hope you can commit the change (renaming a patch file) at your earliest convenience.
On it