install.RStudio doesn't work because 2 exe URLs present in rstudio download site

[burgerga]

https://rstudio.com/products/rstudio/download/#download contains 2 links for downloading rstudio (the big button and the link below All Installers)

That means that at https://github.com/talgalili/installr/blob/master/R/install.R#L848, URL is a character vector of length 2. RStudio is downloaded correctly, but then in installr::install.URL

exe_filename <- file.path(download_dir, file.name.from.url(exe_URL))
...
install_cmd <- exe_filename

causes exe_filename and install_cmd also to be vectors of length 2, which in turn crashes the system call with

Error in system(command, as.integer(flag), f, stdout, stderr, timeout) : 
  character string expected as first argument

So probably, install.RStudio should only pass a single URL to install.URL, and maybe install.R should check if exe_URL is a single URL.

[talgalili]

Thanks, any chance you can propose a pull-request on this?

…

On Fri, May 29, 2020 at 2:43 PM Gerhard Burger ***@***.***> wrote: https://rstudio.com/products/rstudio/download/#download contains 2 links for downloading rstudio (the big button and the link below *All Installers*) That means that at https://github.com/talgalili/installr/blob/master/R/install.R#L848, URL is a character vector of length 2. RStudio is downloaded correctly, but then in installr::install.URL exe_filename <- file.path(download_dir, file.name.from.url(exe_URL))...install_cmd <- exe_filename causes exe_filename and install_cmd also to be vectors of length 2, which in turn crashes the system call with Error in system(command, as.integer(flag), f, stdout, stderr, timeout) : character string expected as first argument So probably, install.RStudio should only pass a single URL to install.URL, and maybe install.R should check if exe_URL is a single URL. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#153>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHOJBWIFDAWXB4QIFSISLDRT6NWNANCNFSM4NN66RNQ> .

[burgerga]

Yes, no problem!

…

On Sun, May 31, 2020 at 8:11 PM Tal Galili ***@***.***> wrote: Thanks, any chance you can propose a pull-request on this? On Fri, May 29, 2020 at 2:43 PM Gerhard Burger ***@***.***> wrote: > https://rstudio.com/products/rstudio/download/#download contains 2 links > for downloading rstudio (the big button and the link below *All > Installers*) > > That means that at > https://github.com/talgalili/installr/blob/master/R/install.R#L848, URL > is a character vector of length 2. RStudio is downloaded correctly, but > then in installr::install.URL > > exe_filename <- file.path(download_dir, file.name.from.url(exe_URL))...install_cmd <- exe_filename > > causes exe_filename and install_cmd also to be vectors of length 2, which > in turn crashes the system call with > > Error in system(command, as.integer(flag), f, stdout, stderr, timeout) : > character string expected as first argument > > So probably, install.RStudio should only pass a single URL to install.URL, > and maybe install.R should check if exe_URL is a single URL. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#153>, or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAHOJBWIFDAWXB4QIFSISLDRT6NWNANCNFSM4NN66RNQ > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#153 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG5QYVRESDSG64MNGBYEOLRUKMWRANCNFSM4NN66RNQ> .

[talgalili]

Thanks :)

…

On Tue, Jun 2, 2020, 08:51 Gerhard Burger ***@***.***> wrote: Yes, no problem! On Sun, May 31, 2020 at 8:11 PM Tal Galili ***@***.***> wrote: > Thanks, any chance you can propose a pull-request on this? > > > On Fri, May 29, 2020 at 2:43 PM Gerhard Burger ***@***.*** > > wrote: > > > https://rstudio.com/products/rstudio/download/#download contains 2 links > > for downloading rstudio (the big button and the link below *All > > Installers*) > > > > That means that at > > https://github.com/talgalili/installr/blob/master/R/install.R#L848, URL > > is a character vector of length 2. RStudio is downloaded correctly, but > > then in installr::install.URL > > > > exe_filename <- file.path(download_dir, > file.name.from.url(exe_URL))...install_cmd <- exe_filename > > > > causes exe_filename and install_cmd also to be vectors of length 2, which > > in turn crashes the system call with > > > > Error in system(command, as.integer(flag), f, stdout, stderr, timeout) : > > character string expected as first argument > > > > So probably, install.RStudio should only pass a single URL to > install.URL, > > and maybe install.R should check if exe_URL is a single URL. > > > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub > > <#153>, or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/AAHOJBWIFDAWXB4QIFSISLDRT6NWNANCNFSM4NN66RNQ > > > > . > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#153 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAG5QYVRESDSG64MNGBYEOLRUKMWRANCNFSM4NN66RNQ > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#153 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHOJBW2OYMJ5JOQ77NAYYDRUSHOLANCNFSM4NN66RNQ> .