tamago324/lir.nvim

Some issues with README

ishan9299 opened this issue · 4 comments

I don't think the Screenshots are actually present in the images repo. I tried to download them but it didn't happen.

Also in lir setup if the if I comment out the this portion :-

  float = {
    size_percentage = 0.5,
    winblend = 15,
    border = true,
    borderchars = {"╔" , "═" , "╗" , "║" , "╝" , "═" , "╚", "║"},
    shadow = true,
  },

I am able to see the window borders. If these are not commented out I can't see the borders.

I think it is kind of difficult to figure out how to open a non-floating window.

Thank you for reporting the issue.
The following is my response.

I don't think the Screenshots are actually present in the images repo. I tried to download them but it didn't happen.

A screenshot is available at tamago324/images.

Also in lir setup if the if I comment out the this portion :-
...

Sorry about the settings, the example in README.md was not correct.
I will fix it.

I think it is kind of difficult to figure out how to open a non-floating window.

By non-floating window, do you mean opening lir.nvim with a normal buffer?
If so, you can use commands like :edit . and :edit %:p:h to open it.

I am not familiar with English, so I would appreciate it if you could tell me if I am reading something wrong.

README.md has been fixed. dc57782
If shadow is set to true, the value of borderchars will be ignored.

Screenshot from 2021-04-29 19-00-45
This is how it looks on my laptop but I was able to see the screenshots in the github mobile app.
EDIT:-
I am not able to see my own screenshots in my browser. closing

@ishan9299 It was displaying correctly from my browser, so I assumed it was fine.
I have created a PR (#11) , could you please check it if possible?