tc39/proposal-Array.prototype.includes

Issues

• Element.classList.contains but Array.prototype.includes?

  #38 opened 4 years ago by sularome
  1

• Why is includes for empty string is always true.

  #39 opened 7 years ago by Punith-Mithra
  2

• why is includes not implemented like the other related methods (find, findIndex etc.)

  #37 opened 7 years ago by marcelh-gh
  3

• Should we deal with holes?

  #15 opened 10 years ago by domenic
  8

• [NaN].includes(NaN) === true?

  #29 opened 9 years ago by jacobp100
  10

• add "excludes" for symmetry

  #35 opened 9 years ago by mahonnaise
  1

• Advance to stage 4

  #13 opened 9 years ago by domenic
  0

• Get into JavaScriptCore

  #9 opened 9 years ago by domenic
  6

• Get into SpiderMonkey: %TypedArray%.prototype.includes

  #28 opened 9 years ago by domenic
  0

• Get into SpiderMonkey

  #8 opened 9 years ago by domenic
  1

• Add "includes" to unscopables?

  #34 opened 9 years ago by anba
  1

• Link to 'contains' rationale broken

  #33 opened 9 years ago by brylie
  1

• Get into V8

  #7 opened 9 years ago by domenic
  5

• Get into V8: %TypedArray%.prototype.includes

  #27 opened 9 years ago by domenic
  1

• Advance to stage 3

  #12 opened 9 years ago by domenic
  2

• Get review from ES spec editor

  #11 opened 9 years ago by domenic
  1

• Holes?

  #31 opened 9 years ago by ljharb
  2

• Put tests in separate module

  #30 opened 10 years ago by ljharb
  9

• They fail for NaN, as indexOf uses Strict Equality Comparison and thus [NaN].indexOf(NaN) === -1.

  #25 opened 10 years ago by Yaffle
  0

• Using SameValue is not a good idea for the same reasons it is not used by Map and Set.

  #24 opened 10 years ago by Yaffle
  0

• Advance to stage 2

  #10 opened 10 years ago by domenic
  0

• Tests

  #1 opened 10 years ago by domenic
  2

• ToLength is hard to test

  #21 opened 10 years ago by domenic
  1

• Infinities are not properly handled

  #20 opened 10 years ago by domenic
  0

• Publish to npm

  #17 opened 10 years ago by ljharb
  3

• Should Array.prototype.contains be enumerable?

  #19 opened 10 years ago by ljharb
  1

• Is fromIndex good?

  #5 opened 10 years ago by domenic
  2

• Capture indexOf analogy with string

  #14 opened 10 years ago by domenic
  0

• Which equality comparator?

  #4 opened 10 years ago by domenic
  2

• Advance to stage 1

  #6 opened 10 years ago by domenic
  1

• Reference implementation

  #2 opened 10 years ago by domenic
  0

• Documentation

  #3 opened 10 years ago by domenic
  1