tc39/proposal-private-fields-in-in

Path to Stage 4!

ljharb opened this issue · 9 comments

ljharb commented

Stage 4

  • committee approval
  • class fields is stage 4
  • two implementations
  • significant in-the-field experience
  • ecma262 PR approved
  • prepare ecma262 PR (based on top of tc39/ecma262#1668)
  • merge test262 tests
  • write test262 tests (PR)

Stage 3

  • committee approval
  • spec editor signoff (@michaelficarra, since the other editors are a champion or stage 2 reviewers)
  • spec reviewer signoff
  • receive implementor feedback

Stage 2

Stage 1

  • committee approval
michaelficarra commented

@ljharb You'll need to add the new alternative in each of the SDOs defined over RelationalExpression. What's there LGTM though.

  • 🎉1
  • 👀1
syg commented

Contents lgtm.

  • 🎉1
waldemarhorwat commented

So far this seems fine to me but I'd also want to check it against the base proposal. Is there a rendered version of tc39/ecma262#1668 ? Rendering of that one seems to have failed.

  • 👍1
littledan commented

@waldemarhorwat tc39/ecma262#1668 has now been rebased, thanks to @Ms2ger . You can find a rendered version at https://arai-a.github.io/ecma262-compare/?pr=1668 (thanks, @arai-a!)

  • 🎉1
jugglinmike commented

@ljharb I'd be happy to write the Test262 tests. Can you let me know if that's already underway?

  • ❤️1
ljharb commented

@jugglinmike that would be awesome. I haven’t had time to start yet, and i wasn’t sure what the best way would be wrt the generated tests.

jugglinmike commented

Cool. I'll let you know when the patch is up for review

  • ❤️1
  • 🚀1
jugglinmike commented

Here's that patch: tc39/test262#2963

  • ❤️1
  • 👀1
ljharb commented

This proposal is now stage 4!

tc39/proposals@0e01f7e

  • 🎉1