tcplugins/tcWebHooks

999 :: Unexpected exception. Please log a bug on GitHub tcplugins/tcWebHooks. Exception was: null

matt-richardson opened this issue · 9 comments

matt-richardson commented

Expected Behavior

Using a project based webhook sensitive parameter for a bearer auth token should work.

Current Behavior

An error occurs:

999 :: Unexpected exception. Please log a bug on GitHub tcplugins/tcWebHooks. Exception was: null

Debugging it leads me to this line, where it uses previous when it could be null. It should be using newHookParameterModel instead.

Steps to Reproduce (for bugs)

  1. Add a webhook parameter to your project

image

2. Set up a webhook

image

3. Enable bearer authentication

image

4. Run a build 5. See error on `WebHook Execution History Details` page

image

Your Environment

  • tcWebHooks Version: 1.2.0-alpha.8
  • TeamCity Version: 2022.04.3
  • TeamCity server Operating System: linux
  • Are you using a WebHook Template?: yes, but this happens with all of them
netwolfuk commented

Yes! You're right. Thank you @matt-richardson

It looks like a regression from a merge of the two feature branches. It previously was correct here

I'll reproduce and check your PR on the weekend. I need to be sure there are not any other sneaky issues of the same ilk. Alpha 9 on the weekend if I can.

matt-richardson commented

That'd be great - I've just shipped a thing that is intended to rely on these webhooks, so I'm super keen to get this fixed so I can unblock my other project!

Thanks for your help!

  • 👍1
netwolfuk commented

Thanks for your work on it @matt-richardson

matt-richardson commented

Wow. You are a legend. Thanks heaps, @netwolfuk!

netwolfuk commented

Haha. You did all the work. 😂

netwolfuk commented

I forgot to say, thank you for taking the time to test the alpha releases.

matt-richardson commented

No worries - my pleasure!

We've deployed the new version, and it's working a treat 🎉 . Thanks again!

  • 👍1