tdzienniak/entropy

Explain reversed start/stop of system event responses

Closed this issue · 3 comments

mk-pmb commented

In packages/entropy/src/System.js, the this.stopResponding(); and this.startResponding(); look swapped. The comments basically rephrase the code, explaining only that it's about events, but what I wonder a lot more is: Why should a system respond to events when disabled, and not respond when enabled?

tdzienniak commented

It's a bug, thanks for pointing it. I will fix this today after work.

  • 👍1
mk-pmb commented

Now I wonder how your demo games could have worked when enable/disable is swapped.

tdzienniak commented

I simply didn't use this functionality in my demo games. I plan to write test for all features, so bugs like this will be caught.