Font size difference in code vs text
Closed this issue · 6 comments
It seems to be a deliberate decision, but I find the difference in markdown text size and code size (14px vs 15px) quite frustrating. I noticed that I was subconsciously writing all text as H3 to keep it legible. In the standard themes, all text is 14px. Is it possible to make this an option, or revert to the 14px standard? Thank you for a really awesome theme.
Actually, while it is true that the standard text/rendered markdown font size is 14px, the standard code font size is only 13px. So you're running into basically the same problem with the standard themes, though maybe it's less noticable.
I think that Consolas (the font I use for this theme) is a bit illegible at 13px, and looks best at 15px, so the short answer is that I won't fix this. The defaults will stay as they are.
The longer answer is that code font size is now a user settable option, so I'll look into making the theme look pretty (or at least consistent) at any size.
I apologise, you are indeed correct that the code font size is 13px by default. I understand that you prefer to keep the defaults, however I think the discrepancy as it stands is less ideal than the default sizes. In default JLab, markdown is slightly larger than code, whereas here code looks significantly larger than markdown:
Darcula:
Default:
Although subtle, in the top image, the code is more distinct from the markdown than in default. This means that in notebooks where there is a fair amount of code per code cell, and a small amount of text per markdown cell, the narrative (markdown) is easily overlooked and harder to read.
Of course, this is just my opinion! If you still feel that the defaults are reasonable, your proposed solution would be fantastic, and much appreciated :)
Though I've spent a lot of time working on the jlab theming/ux stuff, I am not, by any stretch, a graphic designer. I can kind of see what you're talking about, if I maybe squint and cross my eyes a bit?
I won't shrink the Consolas size, but if it's the inconsistency that bothers you, I suppose the other obvious solution would be to bump up the default standard text size up to 15px. I'm ambivalent, but if you want you can submit a PR and I'll pull and publish it on npm.
If you get creative with the CSS, there's probably even a way to get the font-size increase to apply to the rendered markdown alone. I'll leave it in your hands/judgement
I should probably open a new issue, but I've also noticed that the cell number is contracted when the input cell reaches 100:
Do you have any idea why?
Closing this as fixed in jupyterlab/jupyterlab#6926, which allows for user set font sizes. @agoose77 If you want to try it out it's part of the latest Jlab v1.1.0 release candidate.
Awesome, thanks @telamonian !