tensorchord/envd

feat: support gpu more than one

aseaday opened this issue · 5 comments

aseaday commented

envd/pkg/app/up.go

Line 218 in cb90327

NumGPU: numGPU,

envd/pkg/app/up.go

Line 200 in cb90327

numGPU = 1

It seems that we only support GPU=1, more and more developers use a multi card server to develop model. Maybe we should give a settings here.

aseaday commented

I have two ideas to fix this problems:

  1. add an option for envd up and remove config.gpu
  2. make config.gpu work.

I prefer the first solution. But maybe I need more information of envd server's user case.

VoVAllen commented

I think we can make it a cli args for now. Config.gpu will only add a label to the image. The runtime behavior depends on the actual runner

  • 👍1
aseaday commented

I will add a cli arg for control gpus.

arugal commented

@aseaday Hi, this feature is very useful to me. Is there any progress on it now? Maybe I can help.

aseaday commented
  • 😄1
  • 🚀2