the-ditanian-fleet/waitlist

TESTS

Opened this issue · 1 comments

Lyari-Elatha commented
  • fix preexisting unit tests
  • create unit tests that are missing
samuelgrant commented

Would recommend adding a GH Action to test the build process of backend/ when PRs are opened against Main.

I ran into an issue with PR #140 where code would compile in my dev environment, but another contributor had issues. It looks like the latest version of Rust might be more forgiving and that I was using a feature that was introduced fairly recently that other collaborators might not have access to.

A GH Action that runs on pull_request: that installs the version of Rust that we use on prod could help us spot these issues before code is merged to main.

Edit: 06:51 18/8 - I worked out where the property issue was coming from, my database made use of different capitalisation than the migrations I wrote. However, the other issue still stands and I'd still suggest we add a workflow to test the backend code for compilation errors.