thenewboston-blockchain/Bank

Unit test failed when Faker().pytest() = 0

DucPhamTV opened this issue · 2 comments

Bug Description
Unit test is failed when Faker().pytest() = 0

Steps to Reproduce
Steps to reproduce the behavior:

I had enough luck to encounter the failure at https://github.com/thenewboston-developers/Bank/pull/114/checks?check_run_id=1493520739

pyint() will return a random number from 0 to 9999 as default. 0 is not a valid for a transaction amount.

Expected behavior
Tests would never fail

Actual behavior
Probability 1/10000 the tests can be failed

Screenshots/Recordings
No.

OS and Browser
Ubuntu-20.04

Additional context
No

Account Number
ec5aa47719460ee5bcd16ab3cfe94c521d702eb9fc7d80f603762c23014f8ab8

Hi @odetolataiwo ,
I haven't received the payment for this one. My account is ec5aa47719460ee5bcd16ab3cfe94c521d702eb9fc7d80f603762c23014f8ab8
I don't see any transaction with amount 2000 to the account.

Hi again, I see the transaction when I switch to another bank. Thank you anyway!