Revamp functions to use DEFAULT values

Question

Revamp functions to use DEFAULT values

RekGRpth opened this issue 3 years ago · 11 comments

SELECT has_column('schema'::name, 'table'::name, 'column'::name);

treated as

SELECT has_column('schema'::name, 'table'::name, 'column'::text);

Answer 1 · 2021-11-11T11:40:05.000Z

but

SELECT col_not_null('schema'::name, 'table'::name, 'column'::name);

treated right!

Answer 2 · 2021-11-12T03:07:41.000Z

also col_has_default has same bug

Answer 3 · 2021-11-12T08:18:17.000Z

also col_hasnt_default has same bug

Answer 4 · 2021-11-12T08:18:26.000Z

also col_default_is has same bug

Answer 5 · 2021-11-12T08:45:17.000Z

also has_pk has same bug

Answer 6 · 2021-11-12T08:46:14.000Z

also hasnt_pk has same bug

Answer 7 · 2021-11-12T08:49:58.000Z

also col_is_pk has same bug

Answer 8 · 2021-11-12T08:50:07.000Z

also col_isnt_pk has same bug

Answer 9 · 2021-11-12T09:10:24.000Z

also has_unique has same bug

Answer 10 · 2021-11-12T09:10:34.000Z

also col_is_unique has same bug

Answer 11 · 2021-11-14T22:15:28.000Z

col_not_null()'s use of description TEXT DEFAULT NULL as the last argument might be the reason it works better. Now that we've dropped support for v9.0 and earlier, it might make sense to refactor many of the older functions to use that syntax, as it simplifies the code and might well address resolution issues such as @RekGRpth mentions here. Lotta work, though, and not gonna happen before we ship 1.2.0, but I would certainly welcome a PR making such a change.