theref/sage-game-theory

Work on 16333 to develop gambit

Closed this issue · 10 comments

drvinceknight commented

This will need to grab code from old-16333 and also include gambit as an optional package. This needs @theref and I to talk about it though.

drvinceknight commented

Have got the parser documented and tested for LCP.

drvinceknight commented

Have added a bunch of tests that now fail. Let me know if/when you're working on this. If I don't hear from you I will probably keep going with it.

No harm in adding more and/or checking if they're (as well as the docs around them) correct.

I've used # optional - gambit, lrs at some point to say a test that should only run if both optional packages are installed. I'm not sure if that syntax is correct...

drvinceknight commented

A part from potentially removing or at least refactoring the conversion of gambit output to integer where possible (not at all sure why this is in there, see my comment here: a16dc89 - perhaps work on features that we haven't discussed on branches so that we can talk about them...) this is more or less done. Two things are needed:

  1. Allowing init to take a gambit game
  2. Thorough re-read of everything
drvinceknight commented

c402408 now has gambit fully integrated. It needs refactoring though as I'm importing gambit everywhere (and in ways that will crash if gambit is not installed).

Once that is fixed there are two remaining things before pushing to trac:

  1. Discuss parser (see comment here a16dc89)
  2. Thorough check and documentation (including moving part about running gambit in ipython etc...)
drvinceknight commented

Also, the _gambit_game method will need a couple of tests.

drvinceknight commented

This has removed the integer formatting: fa5f6e7

drvinceknight commented

I think gambit is now being called in the best way possible (based on: https://groups.google.com/forum/#!topic/sage-devel/E4Qe15oRTbc). Here's the commit fa5f6e7. I expect that it might change after reviews...

Just a thorough read through left now :)

drvinceknight commented

Just about to push this to trac!

drvinceknight commented

Ok I've pushed a branch that corresponds to 16333 but is all rebased and stuff... https://github.com/theref/sage-game-theory/tree/rebased_version

I'm guessing that once reviews come in I'll work on that one... No idea what is going on.