fold-entity-row glitches on iOS if it contains another fold-entity-rows
ildar170975 opened this issue · 16 comments
My Home Assistant version: 2021.12.6
Fold-entity-row version (FROM BROWSER CONSOLE): 20.0.12
What I am doing:
Expanding a fold-entity-row on iPad client.
This row contains another fold-entity-rows.
What I expected to happen:
- Row is expanded.
- All inserted rows are visible & work properly.
What happened instead:
iPad Air 2 (iOS 15.x):
the last row is clipped:
Btw, what we see on iPhone 5S (iOS 12.x):
Basically I see this (the picture including other rows above the test card):
(related to another issue - #198), but if I managed to display it (after cleaning cache, reloading App) then I just cannot expand some rows (at least containing another fold-entity-rows, button-rows and other conventional rows supported in Entities card).
Minimal steps to reproduce:
type: entities
entities:
- sun.sun
- type: custom:fold-entity-row
head:
type: section
label: section
padding: 10
open: false
entities:
- sun.sun
- type: custom:fold-entity-row
head:
type: section
label: section
padding: 10
open: false
entities:
- entity: sun.sun
- entity: sun.sun
- type: custom:fold-entity-row
head:
type: section
label: section
padding: 10
open: false
entities:
- entity: sun.sun
- entity: sun.sun
Error messages from the browser console:
no
By putting an X in the boxes ([X]) below, I indicate that I:
- Understand that this is a channel for reporting bugs, not a support forum (https://community.home-assistant.io/).
- Have made sure I am using the latest version of the plugin.
- Have followed the troubleshooting steps of the "Common Problems" section of https://github.com/thomasloven/hass-config/wiki/Lovelace-Plugins.
- Understand that leaving one or more boxes unticked or failure to follow the template above may increase the time required to handle my bug-report, or cause it to be closed without further action.
Do not see it in 12.0.4
Great! I forgot to ping this issue when I updated - sorry.
Guess I'm dusting off the ipad air 1 again...
So, on iPad Air 2 - OK, on iPhone 5S - not OK...
Should be fixed now.
Now it is broken even for iPad Air 2 (iOS 15.x) and even for a case "fold-entity-row does NOT contain another fold-entity-row" (((
type: entities
entities:
- entity: sun.sun
secondary_info: last-changed
- type: custom:fold-entity-row
head:
entity: sun.sun
secondary_info: last-changed
padding: 5
no_animation: true
open: true
entities:
- entity: sun.sun
secondary_info: last-changed
- entity: sun.sun
secondary_info: last-changed
- type: custom:fold-entity-row
head:
type: section
label: Section
padding: 5
open: true
group_config:
secondary_info: last-changed
icon: mdi:desk-lamp
entities:
- sun.sun
- sun.sun
- type: section
- type: custom:fold-entity-row
head:
entity: input_boolean.test_boolean
padding: 50
open: false
entities:
- entity: sun.sun
- entity: sun.sun
secondary_info: last-changed
Mobile App was tested after resetting a frontend cache.
I am getting similar issues as @dapuzz on 2.0.15 release, the 2.0.14 works fine for me. Seems to effect Safari / iOS
I pulled 2.0.15 back and rereleased. If you were very quick to install it, you may need to remove fold-entity-row completely and reinstall.
What I did is:
- Uninstall fold-entity-row in HACS.
- Restart HA.
- Install fold-entity-row in HACS.
- Reset frontend cache on iPhone.
And still the card is displayed malformed.
Shall I do additional actions when uninstalling fold-entity-row?
This photo shows 20.0.15 running on Firefox under Linux, Chrome under linux, Safari under macOS 10.15.7, Safari under iOS 15.3, Home Assistant Companion under iOS 14.4.2 and Safari under iOS 12.5.5.
All with no trace of the problems described. Also all showing a visual difference that's unique to 20.0.15 but is absent from all screenshot posted in #192, #199 and #206.
I've made a new release (2.1.0) to maybe force HACS to update correctly.
2.1.0 fixed my issue. Thank you Thomas.
Great! Thank you, Thomas!