test implementation are missing
Closed this issue · 2 comments
Hi,
During some development on this task i found out there was not any test available.
I suggest to put here some hints for an eventual implementation of those later.
a node js ssh server
https://github.com/rvagg/node-libssh
May you have anything useful regarding that subject, post it here.
+1. This is my main hesitation about merging PRs since I need to manually test the code.
since then i would suggest to setup a vagrant file. It would work both windows / linux.
For travis, we should skip vagrant and use direct ssh connection to the localhost.
I did that for another module which does sftp transfers too,
relevant links,
https://github.com/maboiteaspam/ssh2-utils/blob/master/.travis-ssh.sh
https://github.com/maboiteaspam/ssh2-utils/blob/master/Vagrantfile
https://github.com/maboiteaspam/ssh2-utils/blob/master/.travis.yml
Closing it for now.