`css.global` doesn't vendor-prefix rules

[keyz]

Late to the game, but using glamor feels greeeeat! Thanks for making this.

I noticed rules that are inserted via css.global(...) don't get vendor-prefixed. Is this intentional? In my case, I'm using css.global(...) to style the node that ReactDOM renders to:

css.global('#container', {
  minHeight: '100%',
  display: 'flex',
});

IMO it makes perfect sense for css.insert to insert a raw CSS string as-is, but it would be great if css.global can auto-prefix rules such that I won't need to manually add vendor prefixes. :)

[threepointone]

Good point, I hadn't thought of it and it slipped my mind. Will do!

…

On Sun, 4 Dec 2016 at 1:43 PM, Keyan Zhang ***@***.***> wrote: Late to the game, but using glamor feels greeeeat! Thanks for making this. I noticed rules that are inserted via css.global(...) don't get vendor-prefixed. Is this intentional? In my case, I'm using css.global(...) to style the node that ReactDOM renders to: css.global('#container', { minHeight: '100%', display: 'flex', }); IMO it makes perfect sense for css.insert to insert a raw CSS string as-is, but it would be great if css.global can auto-prefix rules such that I won't need to manually add vendor prefixes. :) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#145>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABJeCzSIO85cZt4QFoBsas5AnukWed2ks5rEnYMgaJpZM4LDh1a> .

[keyz]

Thanks @threepointone!

[codepunkt]

Also, nesting and other shenanigans that are possible with css are not applied.
Not sure how much work that would be - totally fine to me without.

[threepointone]

yeah, I probably won't bring nesting etc into this. just a helper for inserting global css.

[threepointone]

published in 2.20.13