TypeError: Invalid value used as weak map key

Question

TypeError: Invalid value used as weak map key

Closed this issue 8 years ago · 20 comments

abhiaiyer91 commented 8 years ago

Hey there Sunil,

After uprading to 2.20.13, I'm getting this error

TypeError: Invalid value used as weak map key on load of my site.

Any clue?

abhiaiyer91 commented 8 years ago

on it

Answer 1 · 2016-12-28T04:27:54.000Z

I must have broken something, will check. Do you have some sample css its breaking on?

…

On Wed, 28 Dec 2016 at 8:22 AM, Abhi Aiyer ***@***.***> wrote: Hey there Sunil, After uprading to 2.20.13, I'm getting this error TypeError: Invalid value used as weak map key on load of my site. Any clue? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#170>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABJeJp8kl68Zsl_Lc5F79PHTbmTCzU7ks5rMc7bgaJpZM4LWow5> .

Answer 2 · 2016-12-28T04:31:41.000Z

Damn I wish I had some sample css for you, its hard to parse given my Meteorjs errors. Let me look and ill get back to you.

Answer 3 · 2016-12-28T04:32:28.000Z

I'm investigating too, will let you know.

…

On Wed, 28 Dec 2016 at 10:01 AM, Abhi Aiyer ***@***.***> wrote: Damn I wish I had some sample css for you, its hard to parse given my Meteorjs errors. Let me look and ill get back to you. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#170 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABJeCtO5yrQKFm28NutfxqY9cTa5k3dks5rMeYugaJpZM4LWow5> .

Answer 4 · 2016-12-28T04:40:45.000Z

My guess is you're sending an actual string as input into css() somewhere.

…

On Wed, 28 Dec 2016 at 10:07 AM, Sunil Pai ***@***.***> wrote: I'm investigating too, will let you know. On Wed, 28 Dec 2016 at 10:01 AM, Abhi Aiyer ***@***.***> wrote: Damn I wish I had some sample css for you, its hard to parse given my Meteorjs errors. Let me look and ill get back to you. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#170 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABJeCtO5yrQKFm28NutfxqY9cTa5k3dks5rMeYugaJpZM4LWow5> .

Answer 5 · 2016-12-28T04:41:53.000Z

Let me verify this brb!

Answer 6 · 2016-12-28T04:52:05.000Z

None of my css calls are doing straight up strings. But my webpack devtools arent being too helpful at eval any ideas to help you out?

Answer 7 · 2016-12-28T04:53:44.000Z

I'll put in some code to work around this bug, but do please try to figure out what CSS caused this.

…

On Wed, 28 Dec 2016 at 10:22 AM, Abhi Aiyer ***@***.***> wrote: None of my css calls are doing straight up strings. But my webpack devtools arent being to helpful at eval any ideas to help you out? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#170 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABJeBTQBuMat4dUhuncqD67QGckOFK-ks5rMer2gaJpZM4LWow5> .

Answer 8 · 2016-12-28T05:53:52.000Z

I published 2.20.16 with a try/catch for the above error, and it logs the arguments to console at least once. Give it a spin and lemme know, if it fixes your issue, and what it spits out to console for this error.

Answer 9 · 2016-12-28T16:17:26.000Z

Yo sunil, you were right, it was a css fuck up in another module we have

failed setting the WeakMap cache for args: data-css-wn814s: ""
this should NOT happen, please file a bug on the github repo.

Answer 10 · 2016-12-28T16:18:07.000Z

Thanks so much for putting this log in here. I was wondering if we could do this for any error generated by Glamor? often times its my own doing, but it would be nice to know what blew up since my app is humungous

Answer 11 · 2016-12-28T16:32:18.000Z

Damn, we have a bunch of these in our app. I wonder if the aphrodite shim people have these

foo ? css(bar) : ''

cause i believe null in aphrodite's css blows up

Answer 12 · 2016-12-28T18:43:03.000Z

? null, undefined should work fine in css, was fixed in #42 and #44. just tried it out too.

that error message that got logged looks odd...

I'd be happy to help you debug for a few minutes if you've been able to reproduce this, and can use ngrok or something. Lemme know.

Answer 13 · 2016-12-28T21:25:25.000Z

ok, I think I know what's going on, it's quite subtle. Gimme a day or so and I'll fix this.

Answer 14 · 2016-12-28T21:32:46.000Z

your current workaround should be to avoid sending those strings.

Answer 15 · 2016-12-29T00:16:00.000Z

Yeah what Im saying is null/undefined did not work in aphrodite unless im mistaken. So we had tons of code just returning empty strings. Thus causing this error when we did a sweeping change to use glamor/aphrodite.

Resolving the ternaries to null works out fine for us, just tons of those to go through. Let me know if you need anything else

Answer 16 · 2016-12-29T18:46:51.000Z

I got in a fix for you, live in 2.20.19. lemme know if it works.

Answer 17 · 2016-12-29T18:48:00.000Z

Thanks a lot Sunil. will check this out today! Appreciate the speed!

Answer 18 · 2016-12-29T19:42:40.000Z

You'll appreciate the speed of the new release more :P The aphrodite shim goes very well with the new WeakMap caches, so your app should get faster for free. Lemme know!

Answer 19 · 2017-01-06T09:36:26.000Z

closing this, lemme know if the issue persists. cheers.