thu-ml/tianshou

/test/continuous/test_ppo.py TypeError on torch.distributions

Closed this issue · 3 comments

  • I have marked all applicable categories:
    • exception-raising bug
    • RL algorithm bug
    • documentation request (i.e. "X is missing from the documentation.")
    • new feature request
    • design request (i.e. "X should be changed to Y.")
  • I have visited the source website
  • I have searched through the issue tracker for duplicates
  • I have mentioned version numbers, operating system and environment, where applicable:

Hi,

I'm currently using Tianshou 1.0.0, python 3.11.8, torch 2.2.2 on Debian 12.
I encounter an issue trying to run the following test script for ppo : https://github.com/thu-ml/tianshou/blob/master/test/continuous/test_ppo.py
I get the following TypeError : test_ppo..dist() takes 1 positional argument but 2 were given

How to reproduce error: python test_ppo.py

edit : same thing for mujoco_ppo.py

Yes, the examples on the master have been updated to reflect changes that were merged in #1032 .

If you copy the examples from master, pls install the version currently on master. I will release 1.1.0 soon with the newest changes.

If you want to continue using 1.0.0, you can copy the examples/tests from the corresponding tag instead of from the master branch

Btw, it's also mentioned in the changelog - second to last entry in Breaking Changes section :)

thanks alot