thucydides-webtests/thucydides

RenderedPageObjectView - waitForPresenceOf(byElementCriteria) has hard coded timeout value

Closed this issue · 3 comments

HNygard commented

The hard coded timeout is causing our tests to fail (we need a higher timeout). Had to override in PageObject.

Link to the line:
https://github.com/thucydides-webtests/thucydides/blob/master/thucydides-core/src/main/java/net/thucydides/core/pages/RenderedPageObjectView.java#L93

    /**
     * This method will wait until an element is present on the screen, though not necessarily visible.
     */
    public void waitForPresenceOf(final By byElementCriteria) {
        WebDriverWait wait = new WebDriverWait(driver, 5);
        wait.until(ExpectedConditions.presenceOfElementLocated(byElementCriteria));
//        waitForCondition().until(elementPresent(byElementCriteria));
    }
wakaleo commented

Fair point - can you submit a pull request with your fix? How would you
envisage configuring this value?

On 3 January 2014 07:47, Hallvard Nygård notifications@github.com wrote:

The hard coded timeout is causing our tests to fail (we need a higher
timeout). Had to override in PageObject.

Link to the line:

https://github.com/thucydides-webtests/thucydides/blob/master/thucydides-core/src/main/java/net/thucydides/core/pages/RenderedPageObjectView.java#L93

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/117
.

John Smart | Wakaleo Consulting | +61 407 247 642
Optimizing your software development process
http://www.wakaleo.com | john.smart@wakaleo.com

The dates for the 2014 BDD workshops have been scheduled! Check out our
upcoming _BDD/TDD Master
classes_http://wakaleo.com/training/testing-and-tdd-for-java-developers
and
our Advanced BDD Requirements Workshops
http://wakaleo.com/training/advanced-agile-requirements-workshop, coming
soon to Sydney
http://wakaleo.com/training/testing-and-tdd-for-java-developers/public-courses
*
and *Melbourne
http://wakaleo.com/training/testing-and-tdd-for-java-developers/public-courses!

HNygard commented

Created a pull request. I have not build the project or tested the patch. The patch uses the timeout value that RenderedPageObjectView already have.

wakaleo commented

That would do it, thanks!

Hallvard Nygård wrote:

Created a pull request. I have not build the project or tested the
patch. The patch uses the timeout value that RenderedPageObjectView
already have.

—
Reply to this email directly or view it on GitHub
#117 (comment).