tighten/duster

Fixer does not fix TLint warning about global_namespace_import

Closed this issue · 1 comments

machacekmartin commented

After installing duster with no custom config whatsoever - the command ./vendor/bin/duster lint successfully highlights errors regarding global_namespace_import rule (under Linting using TLint section), but running ./vendor/bin/duster fix does not actually fix these imports.

Example:

Forms\Components\Fieldset::make('General information')

this is marked with Fully Qualified Class Names should only be used for accessing class names warning, but the ./vendor/bin/duster fix command doesnt fix it. it just goes LGTM!

driftingly commented

TLint doesn't fix this linting issue. I looked into it but couldn't find a way to do it reliably. There are too many edge cases having to do with name collisions.

I'll leave this open for now as I consider a solution related to #124 where, if TLint discovers a listing issue, the fix command still fails.

  • 👍1