tighten/tlint-plugin

Error running TLint inspection: this.file.parent must not be null

Closed this issue · 10 comments

loganhenson commented

Unfortunately I don't have the ability to run the plugin on Linux at this time, but I would love to help remedy this issue any way I can.

Perhaps we can get the plugin build setup on Linux with someone?

tetrode commented

I'm familiar with quite some languages but it is quite a while ago I used java. How can I assist you with this issue?

loganhenson commented

On Linux you can clone this repository, then build a release (https://github.com/loganhenson/tlint-plugin#to-build-a-release), then in PhpStorm you can install plugin from disk (when you build a release, it puts the zip file for the plugin build in the build/distributions/ directory).

Then try to reproduce this error, and we can track down what exactly is causing this.

tetrode commented
  • 👍1
danijelk commented

I cloned the repo, built it and installed the plugin from disk - continue using PhpStorm for development and waiting for the error to occur
…
On Tue, 15 Oct 2019 at 20:02, Logan Henson @.***> wrote: On Linux you can clone this repository, then build a release ( https://github.com/loganhenson/tlint-plugin#to-build-a-release), then in PhpStorm you can install plugin from disk (when you build a release, it puts the zip file for the plugin build in the build/distributions/ directory). Then try to reproduce this error, and we can track down what exactly is causing this. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#8?email_source=notifications&email_token=ABM244LKKOH6G6SDBFFSIUDQOYASHA5CNFSM4I73CBL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBJV3EI#issuecomment-542334353>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABM244MSZDIPPZFIWFWQ743QOYASHANCNFSM4I73CBLQ .

Simple install xdebug, make it break on a line and it will crash the plugin.

danijelk commented

Isn't it a matter of just checking if this.file.parent is null and just return null to avoid the error?

https://github.com/loganhenson/tlint-plugin/blob/73296a63535426459e45d2c44a42248b018220df/src/main/kotlin/tlint/ThreadLocalTempActualFile.kt#L47

loganhenson commented

That looks to be the case 👍(PRs open if this indeed fixes the issue for you)

loganhenson commented

New version should be published soon: https://plugins.jetbrains.com/plugin/10703-tlint/update/71440 Thanks so much for your contribution @danijelk !

danijelk commented

np lets see if solves the issue for others as well. I just had those 2 null exceptions, after that got patched xdebug ran fine without issues. And I also saw it parse previous files correctly, so all should be well

loganhenson commented

@danijelk @tetrode Are we good to close this?

  • 👍1
tetrode commented