tkipf/pygcn

the normalize function in utils.py

wangxiaoyunanne opened this issue · 6 comments

Hi,
The normalize function in utils.py only normalize the row of adjacency matrix. While for the tensorflow version the implementation is different. You normalized both row and column. I am wondering will this lead to a difference for performance of GCN in accuracy ?

Best,
Xiaoyun

tkipf commented

Hi,
I want to know which version is better in the classification.

tkipf commented

Well, I think in the function normalize(mx) it normalizes the features by row,
but if the node features are not one-hot form, and each node has its own feature
like node1 : 1,3,7,20,57, which each feature represents different information( just like something similar in traditional machine learning, the different features has different meaning, like age, height, etc)
the each column of features has different dimension,
should I normalize them by column, instead of row??

tkipf commented

THX,I'll have a try