erhe::physics::EmptyShape': cannot instantiate abstract class
goldragoon opened this issue · 1 comments
goldragoon commented
Greetings!
I've faced a compilation error which :
erhe::physics::EmptyShape': cannot instantiate abstract class
on 237th line of C:\Users\imagoworks\dev\erhe\src\erhe\physics\erhe_physics\jolt\jolt_collision_shape.cpp
I think that current EmptyShape::CollideSoftBodyVertices
interface
void CollideSoftBodyVertices(
JPH::Mat44Arg inCenterOfMassTransform,
JPH::Vec3Arg inScale,
JPH::Array<JPH::SoftBodyVertex>& ioVertices,
float inDeltaTime,
JPH::Vec3Arg inDisplacementDueToGravity,
int inCollidingShapeIndex
) const override
{
...
}
should be replaced to
void CollideSoftBodyVertices(
JPH::Mat44Arg inCenterOfMassTransform,
JPH::Vec3Arg inScale,
JPH::SoftBodyVertex* ioVertices,
JPH::uint inNumVertices,
float inDeltaTime,
JPH::Vec3Arg inDisplacementDueToGravity,
int inCollidingShapeIndex
) const override
{
UNREFERENCED_PARAMETER(inNumVertices); // optional for warning suppression
...
}
How do you think about this?
tksuoran commented
Hi,
I only had a quick look (at this email). Fix looks plausible. I really
should make erhe to use Jolt via fixed tag or commit instead of main.
Timo
…On Thu, Oct 5, 2023 at 11:54 AM goldlagoon ***@***.***> wrote:
Greetings!
I've faced a compilation error which :
erhe::physics::EmptyShape': cannot instantiate abstract class on 237th
line of
C:\Users\imagoworks\dev\erhe\src\erhe\physics\erhe_physics\jolt\jolt_collision_shape.cpp
[image: image]
<https://user-images.githubusercontent.com/2537598/272841337-27474d41-8d9c-4733-9960-ae6c4558ede5.png>
I think that current EmptyShape::CollideSoftBodyVertices interface
void CollideSoftBodyVertices(
JPH::Mat44Arg inCenterOfMassTransform,
JPH::Vec3Arg inScale,
JPH::Array<JPH::SoftBodyVertex>& ioVertices,
float inDeltaTime,
JPH::Vec3Arg inDisplacementDueToGravity,
int inCollidingShapeIndex
) const override
{
...
}
should be replaced to
void CollideSoftBodyVertices(
JPH::Mat44Arg inCenterOfMassTransform,
JPH::Vec3Arg inScale,
JPH::SoftBodyVertex* ioVertices,
JPH::uint inNumVertices,
float inDeltaTime,
JPH::Vec3Arg inDisplacementDueToGravity,
int inCollidingShapeIndex
) const override
{
UNREFERENCED_PARAMETER(inNumVertices); // optional for warning suppression
...
}
How do you think about this?
—
Reply to this email directly, view it on GitHub
<#118>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHS2LTF5FZUBXSNNMOYGHTX5ZYVJAVCNFSM6AAAAAA5T4VOOCVHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZDONZUGIZTMMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>