tl-its-umich-edu/my-learning-analytics

Add names to "Lock Goal" checkboxes

Closed this issue · 3 comments

jennlove-um commented

Assignment Planning: Checkboxes do not seem to have a name - but the table has good structure, so giving them a name is a best practice

MyLA Technical Review 7/24 - row 6

Test Plan:

  1. From Chrome Dev Tool --> axe DevTools -- > Full Scan
  2. Replicating the issue: Without the change it will show 'Form elements must have Label'. but after the change it row will disappear
  3. A more precise way of testing this Chrome Dev Tool --> right click on checkbox element --> inspect --> Right side of window ---> click accessibilty Tab in input element ---> Look for `Name' in the accordian style design --> Aria-Label should say "Lock Goal"

Image

zqian commented

@gsilver will you be able to review this issue on Canvas test?

jaydonkrooss commented

I've released the change onto Canvas test

jennlove-um commented

this passes in testing on MyLA beta