tlc-pack/relax

Cleanup remaining low-level intrinsics that uses Attrs to use PrimValue

tqchen opened this issue · 3 comments

tqchen commented

After #392, we cleaned up CallBuiltin.

It would be great migrate the rest of the low-level intrinsics to use PrimValue, these functions include

  • alloc_storage/tensor
  • print/unique
  • Other possible operators that comes with specialized codegen.
slyubomirsky commented

Are we removing attributes entirely from the language?

tqchen commented

I don't think we will remove Attrs entirely atm, but for some of the low-level ops that have special codegen behaviors, moving them to use PrimValue would be more beneficial(so we can for example leverage same codegen for compiled and vm)

slyubomirsky commented

That seems reasonable, thanks.