High Memory usage while using RazorLight
Closed this issue · 5 comments
Hi team,
I have been using the RazorLight engine for resolving my email templates, I am facing high memory usage from the RazorLight engine.
Please find the attached snap of memory usage report, this below snap taken in localhost.
- Continuously triggered 20 requests in loop, the memory takes around 1.3 GB
- Normally app takes below 200 MB, for this RazorLight code processing alone takes High memory usage
- I have removed RazorLight code and checked the memory it just takes around 200MB only for same 20 requests
We have hosted this app in GCP k8s too, there also facing the same issue, sometimes around 6GB memory used when we are having high incoming request.
Used Version: 2.0.0-rc.3
Thanks in advance.
Facing this same issue, Any solution?
@jzabroski do you have any idea on this?
There isn't anything here for me to look at. I am pretty surprised there is a report of high memory usage without a repro or using a professional .NET memory profiling tool. Screenshots of Windows Task Manager Performance tab are not acceptable. It should be immediately obvious where your problem is if you are using professional tools to analyze the problem.
I would also note that in your second screenshot, it does not look like a memory leak is there. That looks pretty steady to me, and does not match your description that your app normally takes only 200MB. Are you really suggesting that one RazorLight request takes 12 hours to execute? There's also no data suggesting you are using 6GB on GCP.
Given your code sample shows you are manually building a new engine on every call, maybe start your investigation there and use dependency injection and see if your performance improves?
Some basic tips:
- When posting an issue, follow the issue template.
- When posting code, don't post a screenshot of the code. (I never understand why people post screenshots of code in their IDE, when they can just paste it - this is like the most annoying behavior unless the person then marks the code up with illustrations to point out some problem. It's like you won't take the time to create a full repro, and you won't even take the time to copy-paste. I am being hard on you because if a team member of mine did this, I would give them the same feedback).
- If it's a performance issue, use a performance tool to measure the problem before going to someone else, who you are not paying, for help and/or blaming them.
- If you have an e-mail generation system that has very high load, you need to either scale out or make the e-mail generation more static content and use donut caching to eliminate memory usage overhead. (I do not volunteer my time any further than this hint, however.)
Closing. Please open a new issue if you have some more concrete details.
@jzabroski "you are manually building a new engine on every call"
We did the same by blindly following examples in Readme.
May I suggest to add to Readme a tip to use dependency injection/singleton to use single instance of razorLightEngine