tokamak-network/crossTrade

add Testing for further development

zzooppii opened this issue · 24 comments

zzooppii commented

I only conducted simple tests for this development(CrossTradeContract). so need the Add Test
Additionally, i plan to conduct additional tests to ensure that no problems occur.
Testing was conducted only based on Thanos Chain, but additional testing is scheduled to be conducted using Titan Chain.

Additional Test List

  • develop Titan Script Test
    • make the titan test environment
    • request(registerd) & provide Test (TON)
    • request(registerd) & provide Test (ERC20)
    • request(registerd) & provide Test (ETH)
    • request(nonRegisterd) & provide Test (TON)
    • request(nonRegisterd) & provide Test (ERC20)
    • request(nonRegisterd) & provide Test (ETH)
    • edit Test(TON)
    • edit Test(ERC20)
    • edit Test(ETH)
    • cancel Test (TON)
    • cancel Test (ERC20)
    • cancel Test (ETH)
    • reprovide Test (TON)
    • reprovide Test (ERC20)
    • reprovide Test (ETH)
    • resendcancel Test (TON)
    • resendcancel Test (ERC20)
    • resendcancel Test (ETH)
    • requestNonRegisteredToken Provide(TON) & request(USDT)
    • requestNonRegisteredToken Provide(USDT) & request(TON)
    • requestNonRegisteredToken Provide(ETH) & request(TON)
    • requestNonRegisteredToken Provide(TON) & request(ETH)
    • requestNonRegisteredToken Provide(USDC) & request(TON)
    • requestNonRegisteredToken Provide(TON) & request(USDC)
    • requestNonRegisteredToken Provide(ETH) & request(USDC)
    • requestNonRegisteredToken Provide(USDC) & request(ETH)
  • Change Logic
    • register Storage change
    • requestRegisteredToken & requestNonRegisteredToken event change
    • add all event parameter chainId
    • delete the payable (editFee)
    • add the event ProvideCT in L1 (function provide)
    • add the event L1CancelCT in L1 (function cancel)
  • Titan Sepolia
    • make the script about RegisterToken (ETH)
    • make the script about Request (ETH)
    • make the script about Provide (ETH)
    • make the script about Edit (ETH)
    • make the script about Cancel (ETH)
    • make the script about RegisterToken (TON)
    • make the script about Request (TON)
    • make the script about Provide (TON)
    • make the script about Edit (TON)
    • make the script about Cancel (TON)
    • make the script about RegisterToken (ERC20)
    • make the script about Request (ERC20)
    • make the script about Provide (ERC20)
    • make the script about Edit (ERC20)
    • make the script about Cancel (ERC20)
    • make the script about ProvideTest (ETH)
    • make the script about resendProvideMessage(ETH)
    • Provide first and if a request with the same information is made
    • Provide first and if a request with the same saleCount but different information is made
    • Edit first and if a request with the same information is made
    • Edit first and if a request with the same saleCount but different information is made
    • Cancel first and if a request with the same information is made
    • Cancel first and if a request with the same saleCount but different information is made
zzooppii commented

add task

  1. L1Cancel event update
  2. New Deploy on Sepolia
  3. Setting the L1 & L2 CrossTradeContract
  4. register the resisteredTokenList (USDT, USDC)
zzooppii commented

add task

  1. L1Provide, L2Claim event update
  2. New Deploy on Sepolia And TitanSepolia
  3. Setting the L1 & L2 CrossTradeContract
  4. register the resisteredTokenList (ETH, TON , TOS, USDT, USDC)
zzooppii commented

add test on Sepolia & TitanSepolia

1.Provide first and if a request with the same information is made
2.Provide first and if a request with the same saleCount but different information is made
3.Edit first and if a request with the same information is made
4.Edit first and if a request with the same saleCount but different information is made
5.Cancel first and if a request with the same information is made
6.Cancel first and if a request with the same saleCount but different information is made

zzooppii commented

6.Cancel first and if a request with the same saleCount but different information is made

Cancel in L1 Tx: https://sepolia.etherscan.io/tx/0x8b32c3c1a583ec6a4722a1c1fdbd0c481d548289346b6db0d2d421c467f27836
Cancel in L2(Fail) Tx: https://explorer.titan-sepolia.tokamak.network/tx/0x81705815746d01eaacbc525d82acfa96421014acd51e2c4aae87e8f30afbb424
Request Tx: https://explorer.titan-sepolia.tokamak.network/tx/0xb4be9c6cb00ff6c0dde167f0e993f04acc0d3e7ea8681329dbc5147fd96ae2a7
resendCancelMessage in L1 Tx: https://sepolia.etherscan.io/tx/0x4196bfa5c2c76e0e19165d6073bfb4a67c7ca376ac1f0a300fa56a2a5e4e2421
resendCancelMessage in L2(need Fail But Success) Tx: https://explorer.titan-sepolia.tokamak.network/tx/0xe4858adfa29d173264e244b16cb0ecaf17fa68de4b1310840e25beb952867a23

@suahnkim Should have failed but succeeded
After analyzing, I found that only Request and SaleCount were important points in Cancel.
Is it correct that other values ​​must match for Cancel to be possible?

suahnkim commented

Let's have a call about the result? @zzooppii