tokamak-network/crossTrade

Issues

• add Testing for further development

  #24 opened 7 months ago by zzooppii
  12

• Write an article for Contract part

  #25 opened 7 months ago by zzooppii
  4

• make document for FrontEnd

  #51 opened 5 months ago by zzooppii
  2

• J_1. L1FastWithdraw.sol:provideFW [medium]

  #2 opened 7 months ago by zzooppii
  2

• Deploy & setting the CrossTradeContract on Sepolia & Titan Sepolia

  #52 opened 6 months ago by zzooppii
  1

• apply codeReview feedback

  #26 opened 6 months ago by zzooppii
  0

• [Gas Efficiencies] optimize gas costs by modifying function visibility

  #34 opened 6 months ago by usgeeus
  5

• [checking: security vulnerability] Function claimCT can be called with incorrect msg.sender

  #49 opened 6 months ago by nguyenzung
  13

• Use indexed paramter for events for off-chain searching

  #48 opened 6 months ago by parth-15
  0

• `claimCT` and `cancelCT` shouldn't be payable

  #44 opened 6 months ago by parth-15
  0

• Setting `Provider` address as `msg.sender` can result in permanant loss of funds

  #43 opened 6 months ago by parth-15
  32

• getEnterHash function and checkToken mapping is not needed and can be removed

  #39 opened 6 months ago by parth-15
  0

• function _approve is redundant and should be removed

  #38 opened 6 months ago by parth-15
  0

• Open Thanos-Sepolia service

  #50 opened 6 months ago by usgeeus
  0

• Different `l1Token` and `l2Token` pair order will mostly remain unfulfilled

  #46 opened 6 months ago by parth-15
  24

• [non-critical] remove `require(dealData[_saleCount].provider == address(0)` where modifier `providerCheck` is applied

  #42 opened 6 months ago by usgeeus
  0

• [Gas Efficiencies] cache storage value to stack or memory

  #40 opened 6 months ago by usgeeus
  0

• [Gas Efficiencies] use `else` insteand of `else if (number ==2)` in makeEncodeWithSignature, post #34 issue

  #35 opened 6 months ago by usgeeus
  0

• if-else ladder in provideCT can be optimized

  #47 opened 6 months ago by parth-15
  3

• [security vulnerability] attackers can take all token on L2 with very small amount of token on L1

  #29 opened 6 months ago by nguyenzung
  7

• [Non-criticial] Make 1,2 constant for the type of the function, and make 0 constant for saleCount when cancel

  #33 opened 6 months ago by usgeeus
  4

• [Non-critical] Rename the function from _approve to _checkAllowance.

  #32 opened 6 months ago by usgeeus
  2

• [security vulnerbility] check `_totalAmount > _fwAmount` in requestRegisteredToken function

  #41 opened 6 months ago by usgeeus
  3

• [Non-critical] change function name `chainInfo` to `setChainInfo`

  #37 opened 6 months ago by usgeeus
  1

• [security vulnerability] requestRegisteredToken is not safe

  #30 opened 6 months ago by nguyenzung
  6

• [Gas Efficiencies] make `crossDomainMessenger` immutable

  #36 opened 6 months ago by usgeeus
  1

• Provider condition is checked twice in `claimCT` and `cancelCT`

  #45 opened 6 months ago by parth-15
  3

• make the Document for 2nd Audit

  #23 opened 6 months ago by zzooppii
  3

• [security vulnerability] A cross trade can be blocked by attackers

  #31 opened 7 months ago by nguyenzung
  8

• [optimize] many storage load

  #27 opened 7 months ago by DevUreak
  3

• [security checking] claimFW can be failed in some cases

  #28 opened 7 months ago by nguyenzung
  4

• J_10 [protocol discussion]

  #11 opened 7 months ago by usgeeus
  7

• Development of token management logic supported by CrossTrade

  #18 opened 7 months ago by zzooppii
  0

• Editing function modification based on L1

  #22 opened 7 months ago by zzooppii
  0

• L2 reentrant logic development

  #21 opened 7 months ago by zzooppii
  0

• J_3 Reentrancy vulnerability [high]

  #5 opened 7 months ago by usgeeus
  3

• Sub-task or description

  #20 opened 7 months ago by zzooppii
  0

• hash does not contain block.time of FW request from L2

  #17 opened 7 months ago by suahnkim
  4

• J_8. optimize getChainId function [optimization]

  #10 opened 7 months ago by usgeeus
  3

• M_1. [gas optimization]

  #3 opened 7 months ago by MarkInc3
  2

• M_3. Transfer return value check & Assembly Check [low ~ medium]

  #15 opened 7 months ago by MarkInc3
  2

• J_12 use check-effect-interaction pattern [low~medium]

  #14 opened 7 months ago by usgeeus
  2

• J_11 cache storage value to stack or memory [gas optimization]

  #13 opened 7 months ago by usgeeus
  2

• J_9 variable starts with lowercase [style guide]

  #12 opened 7 months ago by usgeeus
  2

• J_7. add amount check [medium]

  #9 opened 7 months ago by usgeeus
  2

• J_6. use unchecked [optimization]

  #8 opened 7 months ago by usgeeus
  2

• J_5. change the way the function return [optimization]

  #7 opened 7 months ago by usgeeus
  2

• J_4 onlyEOA modifier [high]

  #6 opened 7 months ago by usgeeus
  2

• J_2. Use safeTransfer [high]

  #4 opened 7 months ago by usgeeus
  2

• test

  #16 opened 8 months ago by zzooppii
  0