tokamak-network/crossTrade

apply codeReview feedback

zzooppii opened this issue · 0 comments

code Reivew Feedback apply
Feedback on Contract and application of Contract upgrades

What to do:

  • apply the Feedback

What's changed:

  • initial request, check whether totalAmount and fwAmount are greater than 0.
  • When editing, fwAmount must be changed to 0 or more.
  • FW name change to CT
  • delete the editCheck Storage & edit requirement
  • Storage name change nativeL1token to l1TON
  • function name changed edit -> editFee
  • fwAmount must also be included in the hash value. #29
  • code more readable #33
  • use else instead of else if #35
  • rename functions #37
  • delete the _approve #38
  • delete the getEntherHash function #39
  • change the load storage #40
  • double check delete #42
  • add onlyEOA #43
  • delete the payable #44
  • delete the require #46
  • events indexed #48
  • add reqruie #49