tpark94/spnv2

inconsistency in quaternion representation and _error_orientation_quaternion function requirement

romaissaMe opened this issue · 1 comments

https://github.com/tpark94/spnv2/blob/dbcf0de8813da56529bb7467a87c6cdacfc46d23/core/engine/inference.py#L116C1-L116C78
hello, I think here q_pr is in format [qw, qx, qy, qz] as returned by pnp function which reorders the elements of the quaternion array and it is passed to the following function which requires q_pr to be [qx, qy, qz, qw]
def _error_orientation_quaternion(q_pr, q_gt):
# q must be [qvec, qcos]
?

Hello,

The comment is not updated. Both q_pr and q_gt are in [qw, qx, qy, qz].