Add api
Closed this issue · 6 comments
Hello again on this occasion again doing tests with my mod which modifies the vanilla animations using player animator to make my mod compatible with this I have required to make mixin to the classes of your animations because for example if I want to play your animation kiero q running as naruto require q disable the animations of the arms in my mod that case I have already done it and it works well but I found a problem when for example do the same with the animations of the bow in the same way I must disable the arms in my mod but there is an error in the mixin Method signature does not match expected signature. I have done and it works fine but I have found a problem when for example to do the same with the bow animations that in the same way I must disable the braces but there is an error in the mixin Method signature does not match expected signature for Inject something that does not happen with the animation in the mixin of the naruto animation and then I make intellij to fix this error and it generates me this
I leave you in passing the example with the class it injects to the naruto animation.
It's some kind of error with the mapping but I really don't understand how to fix it.
Pd: I am using mojang mapping for my mod.
Hm, I think it would be simpler to just define a quick api that mods can on the fly disable animations. The other (initially intended) version would be, that you just also register an animation with a higher priority(probably around the level of the vanilla animations) to just overwrite my animations with yours(as in, the animation class says it wants control over the arms right now. You don't need to actually do anything in that helper class, see the vanilla classes as an example).
Yes, I am in the process of creating an api that will allow other modders to modify the activation and deactivation of the animations for each body part separately if they like it, I just came across this problem and found it extremely curious.
Thanks for your help
As in a PR? I'll soon work on NEA for the 1.21.3 update, so I could quickly throw together an API package to allow registering custom animations correctly and to allow filtering or animation classes. Mixing into stuff like the NarutoRunning isn't the way to go I think.
I was referring to my mod so that other devs could undo my animations but yes it would be good what you suggest.
Mixins are never the best choice anyway hahahahahaha
Then consider it done with the next release in the next 7-ish days (currently busy with irl stuff, and can't release new versions because Forge is still not on 1.21.3).
Ok, thanks again for the help.